]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
watchdog: imx2_wdt: Use register definition in regmap_write()
authorFabio Estevam <fabio.estevam@freescale.com>
Fri, 2 Oct 2015 03:25:28 +0000 (00:25 -0300)
committerWim Van Sebroeck <wim@iguana.be>
Wed, 28 Oct 2015 21:57:17 +0000 (22:57 +0100)
In order to improve readability it is better to pass the register name
definition rather than to pass its hardcoded offset.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/imx2_wdt.c

index 0bb1a1d1b170a098bfcca3a3f5b828450849f9e0..29ef719a6a3c9dde14ac4997724ad4da514ce69d 100644 (file)
@@ -91,7 +91,7 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode,
                                                    struct imx2_wdt_device,
                                                    restart_handler);
        /* Assert SRS signal */
-       regmap_write(wdev->regmap, 0, wcr_enable);
+       regmap_write(wdev->regmap, IMX2_WDT_WCR, wcr_enable);
        /*
         * Due to imx6q errata ERR004346 (WDOG: WDOG SRS bit requires to be
         * written twice), we add another two writes to ensure there must be at
@@ -99,8 +99,8 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode,
         * the target check here, since the writes shouldn't be a huge burden
         * for other platforms.
         */
-       regmap_write(wdev->regmap, 0, wcr_enable);
-       regmap_write(wdev->regmap, 0, wcr_enable);
+       regmap_write(wdev->regmap, IMX2_WDT_WCR, wcr_enable);
+       regmap_write(wdev->regmap, IMX2_WDT_WCR, wcr_enable);
 
        /* wait for reset to assert... */
        mdelay(500);