]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
rtc: rtc-msm6242: remove unnecessary platform_set_drvdata()
authorJingoo Han <jg1.han@samsung.com>
Thu, 27 Jun 2013 23:53:14 +0000 (09:53 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 28 Jun 2013 06:38:34 +0000 (16:38 +1000)
The driver core clears the driver data to NULL after device_release or on
probe failure, since commit 0998d063100 ("device-core: Ensure drvdata =
NULL when no driver is bound").  Thus, it is not needed to manually clear
the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-msm6242.c

index f0e9893ae7be7280eac1ffbabfeb4ae3806448b2..c014fa2ee5e935a529cb18ca29ac8a52bdaff816 100644 (file)
@@ -199,7 +199,6 @@ static int __init msm6242_rtc_probe(struct platform_device *pdev)
        struct resource *res;
        struct msm6242_priv *priv;
        struct rtc_device *rtc;
-       int error;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (!res)
@@ -216,17 +215,11 @@ static int __init msm6242_rtc_probe(struct platform_device *pdev)
 
        rtc = devm_rtc_device_register(&pdev->dev, "rtc-msm6242",
                                &msm6242_rtc_ops, THIS_MODULE);
-       if (IS_ERR(rtc)) {
-               error = PTR_ERR(rtc);
-               goto out_unmap;
-       }
+       if (IS_ERR(rtc))
+               return PTR_ERR(rtc);
 
        priv->rtc = rtc;
        return 0;
-
-out_unmap:
-       platform_set_drvdata(pdev, NULL);
-       return error;
 }
 
 static int __exit msm6242_rtc_remove(struct platform_device *pdev)