]> git.karo-electronics.de Git - linux-beck.git/commitdiff
tty: serial: lpc32xx_hs: don't call tty_flip_buffer_push() twice
authorViresh Kumar <viresh.kumar@linaro.org>
Mon, 19 Aug 2013 14:44:14 +0000 (20:14 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Aug 2013 23:17:34 +0000 (16:17 -0700)
serial_lpc32xx_interrupt() calls __serial_lpc32xx_rx() first and then
tty_flip_buffer_push() immediately after that. But last statement of
__serial_lpc32xx_rx() already called tty_flip_buffer_push()..

So, probably its not required to be called twice. Lets remove one of them.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/lpc32xx_hs.c

index dffea6b2cd7d206314fe6a69ecd0cecc7cce7d56..8fdf6a8fc07429fbcc7afd9d8f362eec28ee9150 100644 (file)
@@ -351,10 +351,8 @@ static irqreturn_t serial_lpc32xx_interrupt(int irq, void *dev_id)
        }
 
        /* Data received? */
-       if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT)) {
+       if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT))
                __serial_lpc32xx_rx(port);
-               tty_flip_buffer_push(tport);
-       }
 
        /* Transmit data request? */
        if ((status & LPC32XX_HSU_TX_INT) && (!uart_tx_stopped(port))) {