]> git.karo-electronics.de Git - linux-beck.git/commitdiff
usbip: remove check for negative values for an unsigned value
authorMárton Németh <nm127@freemail.hu>
Thu, 26 May 2011 07:24:45 +0000 (09:24 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 7 Jun 2011 20:54:19 +0000 (13:54 -0700)
The parameter rhport is unsigned so there is no need checking for
negative values.

This will remove the following warning message when compiling with "make W=1 ...":
  drivers/staging/usbip/vhci_sysfs.c: In function ‘valid_args’:
  drivers/staging/usbip/vhci_sysfs.c:138: warning: comparison of unsigned expression < 0 is always false

Signed-off-by: Márton Németh <nm127@freemail.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/usbip/vhci_sysfs.c

index d9736f9c4028bc38b04850ee3d002c131d888a71..7b6e4a90212f1812caed7505f7a4b432b4af59e9 100644 (file)
@@ -135,7 +135,7 @@ static DEVICE_ATTR(detach, S_IWUSR, NULL, store_detach);
 static int valid_args(__u32 rhport, enum usb_device_speed speed)
 {
        /* check rhport */
-       if ((rhport < 0) || (rhport >= VHCI_NPORTS)) {
+       if (rhport >= VHCI_NPORTS) {
                pr_err("port %u\n", rhport);
                return -EINVAL;
        }