]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
debug_locks.h: make warning more verbose
authorJames Hogan <james.hogan@imgtec.com>
Wed, 20 Mar 2013 04:06:59 +0000 (15:06 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 21 Mar 2013 05:28:20 +0000 (16:28 +1100)
The WARN_ON(1) in DEBUG_LOCKS_WARN_ON is surprisingly awkward to track
down when it's hit, as it's usually buried in macros, causing multiple
instances to land on the same line number.

This patch makes it more useful by switching to:

    WARN(1, "DEBUG_LOCKS_WARN_ON(%s)", #c);

so that the particular DEBUG_LOCKS_WARN_ON is more easily identified and
grep'd for.  For example:

    WARNING: at kernel/mutex.c:198 _mutex_lock_nested+0x31c/0x380()
    DEBUG_LOCKS_WARN_ON(l->magic != l)

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/debug_locks.h

index a975de1ff59feaba6758afa9682ca9203bfc2c42..822c1354f3a69dae20e7f6cacaf340b40ea9d7c4 100644 (file)
@@ -27,7 +27,7 @@ extern int debug_locks_off(void);
                                                                        \
        if (!oops_in_progress && unlikely(c)) {                         \
                if (debug_locks_off() && !debug_locks_silent)           \
-                       WARN_ON(1);                                     \
+                       WARN(1, "DEBUG_LOCKS_WARN_ON(%s)", #c);         \
                __ret = 1;                                              \
        }                                                               \
        __ret;                                                          \