]> git.karo-electronics.de Git - linux-beck.git/commitdiff
net: ip, raw_diag -- Use jump for exiting from nested loop
authorCyrill Gorcunov <gorcunov@openvz.org>
Wed, 2 Nov 2016 12:36:32 +0000 (15:36 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Nov 2016 19:25:26 +0000 (15:25 -0400)
I managed to miss that sk_for_each is called under "for"
cycle so need to use goto here to return matching socket.

CC: David S. Miller <davem@davemloft.net>
CC: Eric Dumazet <eric.dumazet@gmail.com>
CC: David Ahern <dsa@cumulusnetworks.com>
CC: Andrey Vagin <avagin@openvz.org>
CC: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/raw_diag.c

index bf0b8842bf31fa4497414d881542d4fdbf59ddb1..e1a51ca68d23c324b6643234c6af399aacca83e0 100644 (file)
@@ -79,10 +79,11 @@ static struct sock *raw_sock_get(struct net *net, const struct inet_diag_req_v2
                                 * hashinfo->lock here.
                                 */
                                sock_hold(sk);
-                               break;
+                               goto out_unlock;
                        }
                }
        }
+out_unlock:
        read_unlock(&hashinfo->lock);
 
        return sk ? sk : ERR_PTR(-ENOENT);