]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
ARC: [tlb-miss] Redundant PAGE_PRESENT setting
authorVineet Gupta <vgupta@synopsys.com>
Mon, 17 Jun 2013 06:17:33 +0000 (11:47 +0530)
committerVineet Gupta <vgupta@synopsys.com>
Mon, 17 Jun 2013 13:02:25 +0000 (18:32 +0530)
Post TLB entry installation, in updating PTE for software accessed/dity
bits, no need to update PAGE_PRESENT since it will already be set.
Infact the entry won't have installed if !PAGE_PRESENT.

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
arch/arc/mm/tlbex.S

index 06cd4f98d765badfa869a6967f73e1d0bad9ae8b..fcdc19ff6da7746d9b32e7a6a7718d4f57820653 100644 (file)
@@ -285,8 +285,8 @@ ARC_ENTRY EV_TLBMissI
        bnz     do_slow_path_pf
 
        ; Let Linux VM know that the page was accessed
-       or      r0, r0, (_PAGE_PRESENT | _PAGE_ACCESSED)  ; set Accessed Bit
-       st_s    r0, [r1]                                  ; Write back PTE
+       or      r0, r0, _PAGE_ACCESSED  ; set Accessed Bit
+       st_s    r0, [r1]                ; Write back PTE
 
        CONV_PTE_TO_TLB
        COMMIT_ENTRY_TO_MMU
@@ -345,7 +345,7 @@ ARC_ENTRY EV_TLBMissD
        ;----------------------------------------------------------------
        ; UPDATE_PTE: Let Linux VM know that page was accessed/dirty
        lr      r3, [ecr]
-       or      r0, r0, (_PAGE_PRESENT | _PAGE_ACCESSED) ; Accessed bit always
+       or      r0, r0, _PAGE_ACCESSED        ; Accessed bit always
        btst_s  r3,  ECR_C_BIT_DTLB_ST_MISS   ; See if it was a Write Access ?
        or.nz   r0, r0, _PAGE_MODIFIED        ; if Write, set Dirty bit as well
        st_s    r0, [r1]                      ; Write back PTE