]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
PCI: mvebu: Use '%pa' for printing 'phys_addr_t' type
authorFabio Estevam <fabio.estevam@freescale.com>
Tue, 29 Apr 2014 12:58:07 +0000 (09:58 -0300)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 29 Apr 2014 16:47:25 +0000 (10:47 -0600)
Fix the following build warning that happens when building
multi_v7_defconfig with CONFIG_ARM_LPAE=y:

  drivers/pci/host/pci-mvebu.c:334:5: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'phys_addr_t' [-Wformat=]

Fix the warning by using '%pa' to printing 'phys_addr_t' type.  While at
it, also use the more standard notation [mem 0x-0x] for memory region.

[bhelgaas: make end address inclusive, remove extra spaces]
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Jason Cooper <jason@lakedaemon.net>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
drivers/pci/host/pci-mvebu.c

index 29d64c9efa85e388de494fd52b56a538838dde2c..7f450322f397d9b8835526fc8af60639c8a21a7e 100644 (file)
@@ -328,9 +328,11 @@ static void mvebu_pcie_add_windows(struct mvebu_pcie_port *port,
                ret = mvebu_mbus_add_window_remap_by_id(target, attribute, base,
                                                        sz, remap);
                if (ret) {
+                       phys_addr_t end = base + sz - 1;
+
                        dev_err(&port->pcie->pdev->dev,
-                               "Could not create MBus window at 0x%x, size 0x%x: %d\n",
-                               base, sz, ret);
+                               "Could not create MBus window at [mem %pa-%pa]: %d\n",
+                               &base, &end, ret);
                        mvebu_pcie_del_windows(port, base - size_mapped,
                                               size_mapped);
                        return;