]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
osf_getdomainname(): use copy_to_user()
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 14 May 2017 01:39:49 +0000 (21:39 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 27 May 2017 20:21:19 +0000 (16:21 -0400)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
arch/alpha/kernel/osf_sys.c

index 9ec56dc973749555019f5f0087727cc1bb97881a..c4e135db170476a61b7c8c4527406d9e0103ca72 100644 (file)
@@ -564,25 +564,20 @@ SYSCALL_DEFINE0(getdtablesize)
  */
 SYSCALL_DEFINE2(osf_getdomainname, char __user *, name, int, namelen)
 {
-       unsigned len;
-       int i;
+       int len, err = 0;
+       char *kname;
 
-       if (!access_ok(VERIFY_WRITE, name, namelen))
-               return -EFAULT;
-
-       len = namelen;
-       if (len > 32)
-               len = 32;
+       if (namelen > 32)
+               namelen = 32;
 
        down_read(&uts_sem);
-       for (i = 0; i < len; ++i) {
-               __put_user(utsname()->domainname[i], name + i);
-               if (utsname()->domainname[i] == '\0')
-                       break;
-       }
+       kname = utsname()->domainname;
+       len = strnlen(kname, namelen);
+       if (copy_to_user(name, kname, min(len + 1, namelen)))
+               err = -EFAULT;
        up_read(&uts_sem);
 
-       return 0;
+       return err;
 }
 
 /*