drm/sun4i: Fix up error path cleanup for master bind function

The master bind function calls numerous drm functions which initialize
underlying structures. It also tries to bind the various components
of the display pipeline, some of which may add additional drm objects.

This patch adds proper cleanup functions in the error path of the
master bind function.

This requires the patch "drm/sun4i: Move drm_mode_config_cleanup call
to main driver", which splits out drm_mode_config_cleanup from
sun4i_framebuffer_free so we can call it separately.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index cd26ed94c41bf69ff1f9a9b380f0686becc4bd6c..7ae179e88309f8498fcbcc97afb513f3364c480b 100644 (file)
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -108,7 +108,7 @@ static int sun4i_drv_bind(struct device *dev)
        ret = component_bind_all(drm->dev, drm);
        if (ret) {
                dev_err(drm->dev, "Couldn't bind all pipelines components\n");
-               goto free_drm;
+               goto cleanup_mode_config;
        }
 
        /* Create our layers */
@@ -116,7 +116,7 @@ static int sun4i_drv_bind(struct device *dev)
        if (IS_ERR(drv->layers)) {
                dev_err(drm->dev, "Couldn't create the planes\n");
                ret = PTR_ERR(drv->layers);
-               goto free_drm;
+               goto cleanup_mode_config;
        }
 
        /* Create our CRTC */
@@ -124,7 +124,7 @@ static int sun4i_drv_bind(struct device *dev)
        if (!drv->crtc) {
                dev_err(drm->dev, "Couldn't create the CRTC\n");
                ret = -EINVAL;
-               goto free_drm;
+               goto cleanup_mode_config;
        }
        drm->irq_enabled = true;
 
@@ -136,7 +136,7 @@ static int sun4i_drv_bind(struct device *dev)
        if (IS_ERR(drv->fbdev)) {
                dev_err(drm->dev, "Couldn't create our framebuffer\n");
                ret = PTR_ERR(drv->fbdev);
-               goto free_drm;
+               goto cleanup_mode_config;
        }
 
        /* Enable connectors polling */
@@ -144,10 +144,16 @@ static int sun4i_drv_bind(struct device *dev)
 
        ret = drm_dev_register(drm, 0);
        if (ret)
-               goto free_drm;
+               goto finish_poll;
 
        return 0;
 
+finish_poll:
+       drm_kms_helper_poll_fini(drm);
+       sun4i_framebuffer_free(drm);
+cleanup_mode_config:
+       drm_mode_config_cleanup(drm);
+       drm_vblank_cleanup(drm);
 free_drm:
        drm_dev_unref(drm);
        return ret;