ath10k: fix tx hang

The wake_tx_queue/push_pending logic had a bug
which could stop queues indefinitely effectivelly
breaking traffic.

Fixes: 299468782d94 ("ath10k: implement wake_tx_queue")
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index eedfe821700b1b296417ea59a187186607278379..1bc4bf1916a6d88b610123eea98a74d2ffb4256a 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3777,13 +3777,13 @@ void ath10k_mac_tx_push_pending(struct ath10k *ar)
                }
 
                list_del_init(&artxq->list);
+               if (ret != -ENOENT)
+                       list_add_tail(&artxq->list, &ar->txqs);
+
                ath10k_htt_tx_txq_update(hw, txq);
 
-               if (artxq == last || (ret < 0 && ret != -ENOENT)) {
-                       if (ret != -ENOENT)
-                               list_add_tail(&artxq->list, &ar->txqs);
+               if (artxq == last || (ret < 0 && ret != -ENOENT))
                        break;
-               }
        }
 
        rcu_read_unlock();