]> git.karo-electronics.de Git - linux-beck.git/commitdiff
libata: Remove FIXME comment in atapi_eh_request_sense
authorNicholas Krause <xerofoify@gmail.com>
Wed, 7 Jan 2015 05:44:52 +0000 (00:44 -0500)
committerTejun Heo <tj@kernel.org>
Wed, 7 Jan 2015 15:07:20 +0000 (10:07 -0500)
Remove the FIXME comment in  atapi_eh_request_sense () asking whether
memset of sense buffer is necessary.  The buffer may be partially or
fully filled by the device.  We want it to be cleared.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libata-eh.c

index 8d00c2638bed8ea499fb55bcd1b8b660c80be814..a9f5aed32d3993d603133073663941a398f11b76 100644 (file)
@@ -1635,7 +1635,6 @@ unsigned int atapi_eh_request_sense(struct ata_device *dev,
 
        DPRINTK("ATAPI request sense\n");
 
-       /* FIXME: is this needed? */
        memset(sense_buf, 0, SCSI_SENSE_BUFFERSIZE);
 
        /* initialize sense_buf with the error register,