]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
gpio: acpi: Align acpi_find_gpio() with DT version
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 23 May 2017 17:03:17 +0000 (20:03 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 29 May 2017 09:16:11 +0000 (11:16 +0200)
By some reason acpi_find_gpio() and acpi_gpio_count() have compared
connection ID to "gpios" when tries to check if suffix is needed or not.

Don't do any assumptions about what connection ID can be and, when defined,
use it only with suffix as it's done in the device tree version.

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib-acpi.c

index 2185232da823e658c326063dda45aaa2d9a66f71..055a8a255a402c2d8e431c72401a6537498c2d4a 100644 (file)
@@ -599,7 +599,7 @@ struct gpio_desc *acpi_find_gpio(struct device *dev,
 
        /* Try first from _DSD */
        for (i = 0; i < ARRAY_SIZE(gpio_suffixes); i++) {
-               if (con_id && strcmp(con_id, "gpios")) {
+               if (con_id) {
                        snprintf(propname, sizeof(propname), "%s-%s",
                                 con_id, gpio_suffixes[i]);
                } else {
@@ -1089,7 +1089,7 @@ int acpi_gpio_count(struct device *dev, const char *con_id)
 
        /* Try first from _DSD */
        for (i = 0; i < ARRAY_SIZE(gpio_suffixes); i++) {
-               if (con_id && strcmp(con_id, "gpios"))
+               if (con_id)
                        snprintf(propname, sizeof(propname), "%s-%s",
                                 con_id, gpio_suffixes[i]);
                else