]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
imx-drm: imx-ldb: Check 'mode' pointer first
authorFabio Estevam <fabio.estevam@freescale.com>
Wed, 26 Feb 2014 23:53:40 +0000 (20:53 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Feb 2014 22:57:43 +0000 (14:57 -0800)
Fix the following static checker warning:

drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'.  (drm_mode_create returns null)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/imx-drm/imx-ldb.c

index 5168c76cff5336929be23a2f52179be287976b68..abf85170f6d6afbc370a59fc086c9a95eccfe77b 100644 (file)
@@ -106,6 +106,8 @@ static int imx_ldb_connector_get_modes(struct drm_connector *connector)
                struct drm_display_mode *mode;
 
                mode = drm_mode_create(connector->dev);
+               if (!mode)
+                       return -EINVAL;
                drm_mode_copy(mode, &imx_ldb_ch->mode);
                mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
                drm_mode_probed_add(connector, mode);