]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
target: Fix incorrect se_cmd assignment in core_tmr_drain_tmr_list
authorJoern Engel <joern@logfs.org>
Wed, 26 Oct 2011 05:08:43 +0000 (22:08 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Nov 2011 17:44:38 +0000 (09:44 -0800)
commit 80ccbc8e00f7001d79dd503c2781487906b98611 upstream.

This patch fixes a bug in core_tmr_drain_tmr_list() where drain_tmr_list
was using the wrong se_tmr_req for cmd assignment due to a typo during the
LUN_RESET re-org.  This was resulting in general protection faults while
using the leftover bogus *tmr_p pointer from list_for_each_entry_safe().

Signed-off-by: Joern Engel <joern@logfs.org>
Cc: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/target/target_core_tmr.c

index df3e4669c80b3ce467c6d9b6e5d3aa3efc711856..c0deee33037ca7c5fded4dc7e49ec307dbbb2e0b 100644 (file)
@@ -155,7 +155,7 @@ static void core_tmr_drain_tmr_list(
        while (!list_empty(&drain_tmr_list)) {
                tmr = list_entry(drain_tmr_list.next, struct se_tmr_req, tmr_list);
                list_del(&tmr->tmr_list);
-               cmd = tmr_p->task_cmd;
+               cmd = tmr->task_cmd;
 
                pr_debug("LUN_RESET: %s releasing TMR %p Function: 0x%02x,"
                        " Response: 0x%02x, t_state: %d\n",