]> git.karo-electronics.de Git - linux-beck.git/commitdiff
libfcoe: Fix meaningless log statement
authorRobert Love <robert.w.love@intel.com>
Tue, 11 Jun 2013 07:28:19 +0000 (07:28 +0000)
committerRobert Love <robert.w.love@intel.com>
Tue, 9 Jul 2013 18:18:47 +0000 (11:18 -0700)
ctlr_dev was initialized to NULL, and never re-assigned. This
caused the log statement to always report failure. This patch
removes the unused variable and fixes the log statement to always
report 'success', as that is what should be logged if the code
reaches this point.

Signed-off-by: Robert Love <robert.w.love@intel.com>
Tested-by: Jack Morgan <jack.morgan@intel.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
drivers/scsi/fcoe/fcoe_transport.c

index bedd4221172704c871aee8f30b0e851954c2c46d..f1ae5edb2de177f250f313b8afcb70c57607e235 100644 (file)
@@ -707,7 +707,6 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus,
 {
        struct net_device *netdev = NULL;
        struct fcoe_transport *ft = NULL;
-       struct fcoe_ctlr_device *ctlr_dev = NULL;
        int rc = 0;
        int err;
 
@@ -754,9 +753,8 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus,
                goto out_putdev;
        }
 
-       LIBFCOE_TRANSPORT_DBG("transport %s %s to create fcoe on %s.\n",
-                             ft->name, (ctlr_dev) ? "succeeded" : "failed",
-                             netdev->name);
+       LIBFCOE_TRANSPORT_DBG("transport %s succeeded to create fcoe on %s.\n",
+                             ft->name, netdev->name);
 
 out_putdev:
        dev_put(netdev);