]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
media: i2c/adp1653: set enable gpio to output
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 12 Jun 2015 07:04:55 +0000 (09:04 +0200)
committerUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 6 Jul 2015 08:10:22 +0000 (10:10 +0200)
Without setting the direction of a gpio to output a call to
gpiod_set_value doesn't have a defined outcome.

Furthermore this is one caller less that stops us making the flags
argument to gpiod_get*() mandatory.

Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
drivers/media/i2c/adp1653.c

index c70ababce954d1d7ea2965dfe121996b4c0fe161..5dd39775d6ca5c449c1b496c90a275ba6ba9118a 100644 (file)
@@ -465,7 +465,7 @@ static int adp1653_of_init(struct i2c_client *client,
 
        of_node_put(child);
 
-       pd->enable_gpio = devm_gpiod_get(&client->dev, "enable");
+       pd->enable_gpio = devm_gpiod_get(&client->dev, "enable", GPIOD_OUT_LOW);
        if (!pd->enable_gpio) {
                dev_err(&client->dev, "Error getting GPIO\n");
                return -EINVAL;