]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
i2c-i801: Enable interrupts for all post-ICH5 chips
authorJean Delvare <khali@linux-fr.org>
Wed, 31 Oct 2012 23:18:24 +0000 (10:18 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 31 Oct 2012 23:42:20 +0000 (10:42 +1100)
I did not receive a single bug report after interrupt support was
added for a limited number of chips. So I'd say the code is good and
should be enabled for all supported chips, that is: ICH5 and later.

For now the IDF channels are excluded as I have no idea if they
support interrupts too or not.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Daniel Kurtz <djkurtz@chromium.org>
drivers/i2c/busses/i2c-i801.c

index e80eafc48e7838cced28eb2776854f31d0208bfa..c7e91f96558805d4c52c026bf7b521fa5f802d23 100644 (file)
@@ -1109,6 +1109,8 @@ static int __devinit i801_probe(struct pci_dev *dev,
                /* fall through */
        default:
                priv->features |= FEATURE_I2C_BLOCK_READ;
+               if (!(priv->features & FEATURE_IDF))
+                       priv->features |= FEATURE_IRQ;
                /* fall through */
        case PCI_DEVICE_ID_INTEL_82801DB_3:
                priv->features |= FEATURE_SMBUS_PEC;
@@ -1121,16 +1123,6 @@ static int __devinit i801_probe(struct pci_dev *dev,
                break;
        }
 
-       /* IRQ processing tested on CougarPoint PCH, ICH5, ICH7-M and ICH10 */
-       if (dev->device == PCI_DEVICE_ID_INTEL_COUGARPOINT_SMBUS ||
-           dev->device == PCI_DEVICE_ID_INTEL_82801EB_3 ||
-           dev->device == PCI_DEVICE_ID_INTEL_ICH7_17 ||
-           dev->device == PCI_DEVICE_ID_INTEL_ICH8_5 ||
-           dev->device == PCI_DEVICE_ID_INTEL_ICH9_6 ||
-           dev->device == PCI_DEVICE_ID_INTEL_ICH10_4 ||
-           dev->device == PCI_DEVICE_ID_INTEL_ICH10_5)
-               priv->features |= FEATURE_IRQ;
-
        /* Disable features on user request */
        for (i = 0; i < ARRAY_SIZE(i801_feature_names); i++) {
                if (priv->features & disable_features & (1 << i))