]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
iwlwifi: pcie: improve "invalid queue" warning
authorJohannes Berg <johannes.berg@intel.com>
Fri, 26 May 2017 09:16:39 +0000 (11:16 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Thu, 29 Jun 2017 10:26:25 +0000 (13:26 +0300)
Print out both queue IDs to be able to see what went wrong.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/pcie/rx.c

index cd109740632de69619c6e7a9e4236ce6a92f0446..6544facc2e0ce0635d6fa8a8b95539bab883bb39 100644 (file)
@@ -1129,8 +1129,12 @@ static void iwl_pcie_rx_handle_rb(struct iwl_trans *trans,
                if (pkt->len_n_flags == cpu_to_le32(FH_RSCSR_FRAME_INVALID))
                        break;
 
-               WARN_ON((le32_to_cpu(pkt->len_n_flags) & FH_RSCSR_RXQ_MASK) >>
-                       FH_RSCSR_RXQ_POS != rxq->id);
+               WARN((le32_to_cpu(pkt->len_n_flags) & FH_RSCSR_RXQ_MASK) >>
+                       FH_RSCSR_RXQ_POS != rxq->id,
+                    "frame on invalid queue - is on %d and indicates %d\n",
+                    rxq->id,
+                    (le32_to_cpu(pkt->len_n_flags) & FH_RSCSR_RXQ_MASK) >>
+                       FH_RSCSR_RXQ_POS);
 
                IWL_DEBUG_RX(trans,
                             "cmd at offset %d: %s (%.2x.%2x, seq 0x%x)\n",