]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
tracing/uprobes: Rename uprobe_{trace,perf}_print() functions
authorNamhyung Kim <namhyung@kernel.org>
Fri, 17 Jan 2014 08:08:36 +0000 (17:08 +0900)
committerSteven Rostedt <rostedt@goodmis.org>
Thu, 20 Feb 2014 17:30:08 +0000 (12:30 -0500)
The uprobe_{trace,perf}_print functions are misnomers since what they
do is not printing.  There's also a real print function named
print_uprobe_event() so they'll only increase confusion IMHO.

Rename them with double underscores to follow convention of kprobe.

Link: http://lkml.kernel.org/r/1389946120-19610-2-git-send-email-namhyung@kernel.org
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_uprobe.c

index 79e52d93860b6c4a1c73f502b6ec97f4bb8b1bef..c5d2612bf233239b1e8d63d25244815d17270063 100644 (file)
@@ -758,7 +758,7 @@ static void uprobe_buffer_put(struct uprobe_cpu_buffer *ucb)
        mutex_unlock(&ucb->mutex);
 }
 
-static void uprobe_trace_print(struct trace_uprobe *tu,
+static void __uprobe_trace_func(struct trace_uprobe *tu,
                                unsigned long func, struct pt_regs *regs)
 {
        struct uprobe_trace_entry_head *entry;
@@ -807,14 +807,14 @@ out:
 static int uprobe_trace_func(struct trace_uprobe *tu, struct pt_regs *regs)
 {
        if (!is_ret_probe(tu))
-               uprobe_trace_print(tu, 0, regs);
+               __uprobe_trace_func(tu, 0, regs);
        return 0;
 }
 
 static void uretprobe_trace_func(struct trace_uprobe *tu, unsigned long func,
                                struct pt_regs *regs)
 {
-       uprobe_trace_print(tu, func, regs);
+       __uprobe_trace_func(tu, func, regs);
 }
 
 /* Event entry printers */
@@ -1014,7 +1014,7 @@ static bool uprobe_perf_filter(struct uprobe_consumer *uc,
        return ret;
 }
 
-static void uprobe_perf_print(struct trace_uprobe *tu,
+static void __uprobe_perf_func(struct trace_uprobe *tu,
                                unsigned long func, struct pt_regs *regs)
 {
        struct ftrace_event_call *call = &tu->tp.call;
@@ -1078,14 +1078,14 @@ static int uprobe_perf_func(struct trace_uprobe *tu, struct pt_regs *regs)
                return UPROBE_HANDLER_REMOVE;
 
        if (!is_ret_probe(tu))
-               uprobe_perf_print(tu, 0, regs);
+               __uprobe_perf_func(tu, 0, regs);
        return 0;
 }
 
 static void uretprobe_perf_func(struct trace_uprobe *tu, unsigned long func,
                                struct pt_regs *regs)
 {
-       uprobe_perf_print(tu, func, regs);
+       __uprobe_perf_func(tu, func, regs);
 }
 #endif /* CONFIG_PERF_EVENTS */