]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: rtl8192e: Remove if conditions.
authorNavya Sri Nizamkari <navyasri.tech@gmail.com>
Wed, 4 Mar 2015 08:45:05 +0000 (14:15 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Mar 2015 23:30:07 +0000 (15:30 -0800)
This patch removes if conditions with no exececutable
statements in the bodies of those ifs and also no variable
assignments in the if conditional checks. The call to
rtllib_act_scanning in the condition doesn't have any side
effects as it too performs conditional checks without changing
any values. Hence, it's safe to remove the if condition.

Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c

index df0323f00f69c1e808a9a1e790d49740bfba281c..c233a1c1bb312f395786ba3ad788c8889d4c0747 100644 (file)
@@ -572,10 +572,6 @@ static int r8192_wx_set_essid(struct net_device *dev,
        struct r8192_priv *priv = rtllib_priv(dev);
        int ret;
 
-       if ((rtllib_act_scanning(priv->rtllib, false)) &&
-           !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
-               ;       /* TODO - get rid of if */
-       }
        if (priv->bHwRadioOff == true) {
                printk(KERN_INFO "=========>%s():hw radio off,or Rf state is "
                       "eRfOff, return\n", __func__);
@@ -708,11 +704,6 @@ static int r8192_wx_set_wap(struct net_device *dev,
        int ret;
        struct r8192_priv *priv = rtllib_priv(dev);
 
-       if ((rtllib_act_scanning(priv->rtllib, false)) &&
-           !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
-               ;       /* TODO - get rid of if */
-       }
-
        if (priv->bHwRadioOff == true)
                return 0;
 
@@ -763,9 +754,6 @@ static int r8192_wx_set_enc(struct net_device *dev,
                             {0x00, 0x00, 0x00, 0x00, 0x00, 0x03} };
        int i;
 
-       if ((rtllib_act_scanning(priv->rtllib, false)) &&
-          !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN))
-               ;       /* TODO - get rid of if */
        if (priv->bHwRadioOff == true)
                return 0;