]> git.karo-electronics.de Git - linux-beck.git/commitdiff
phy: miphy365x: Fix off-by-one error
authorLee Jones <lee.jones@linaro.org>
Thu, 28 Aug 2014 13:59:50 +0000 (14:59 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Fri, 12 Sep 2014 06:05:31 +0000 (11:35 +0530)
We index the RX/TX speed select values in the following way:

  rx_tx_spd[miphy_phy->sata_gen];

However rx_tx_spd[] starts at index zero and the SATA_GENx's start
at one.  In this patch we pad out the first element in rx_tx_spd[]
in an attempt to realign the values.

Cc: Alexandre Torgue <alexandre.torgue@st.com>
Reported-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-miphy365x.c

index e111baf187ce2d4a37484601e41fa29ca7e757bb..e0fb7a1e5a5a9c9cf0be5fc109ba09556cb35593 100644 (file)
@@ -163,6 +163,7 @@ enum miphy_sata_gen {
 };
 
 static u8 rx_tx_spd[] = {
+       0, /* GEN0 doesn't exist. */
        TX_SPDSEL_GEN1_VAL | RX_SPDSEL_GEN1_VAL,
        TX_SPDSEL_GEN2_VAL | RX_SPDSEL_GEN2_VAL,
        TX_SPDSEL_GEN3_VAL | RX_SPDSEL_GEN3_VAL