]> git.karo-electronics.de Git - linux-beck.git/commitdiff
net: fec: correct phy_name buffer length when init phy_name
authorRichard Zhao <richard.zhao@linaro.org>
Sun, 29 Jan 2012 22:08:12 +0000 (22:08 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 31 Jan 2012 21:17:25 +0000 (16:17 -0500)
Fix the bug that we got wrong phy_name on imx6q sabrelite board.
snprintf used wrong length of phy_name.
phy_name length is MII_BUS_ID_SIZE + 3 rather not MII_BUS_ID_SIZE.
I change it to sizeof(phy_name).

Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec.c

index 7b25e9cf13f6ff5a6c141cd6c6bd478fe5e5c6fb..1c7aad8fa19c80cbdbe5a61fdd2c677f555f559f 100644 (file)
@@ -990,7 +990,7 @@ static int fec_enet_mii_probe(struct net_device *ndev)
                phy_id = 0;
        }
 
-       snprintf(phy_name, MII_BUS_ID_SIZE, PHY_ID_FMT, mdio_bus_id, phy_id);
+       snprintf(phy_name, sizeof(phy_name), PHY_ID_FMT, mdio_bus_id, phy_id);
        phy_dev = phy_connect(ndev, phy_name, &fec_enet_adjust_link, 0,
                              fep->phy_interface);
        if (IS_ERR(phy_dev)) {