]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
fbdev: Minor cleanup in WM8505-related code
authorAlexey Charkov <alchark@gmail.com>
Mon, 20 Dec 2010 13:03:14 +0000 (16:03 +0300)
committerPaul Mundt <lethal@linux-sh.org>
Mon, 20 Dec 2010 16:05:43 +0000 (01:05 +0900)
This replaces the last remaining driver name reference with the
macro for uniformity in wm8505fb.

In addition, the error return path in wmt_ge_rops.c is made more
uniform by getting rid of goto's in remaining places.

Signed-off-by: Alexey Charkov <alchark@gmail.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
drivers/video/wm8505fb.c
drivers/video/wmt_ge_rops.c

index e37251b792c951dbc5040b9a0b53631da862abc4..9ca9dbb62f965e390dec7d91058db815532966d2 100644 (file)
@@ -291,7 +291,7 @@ static int __devinit wm8505fb_probe(struct platform_device *pdev)
                goto failed_fbi;
        }
 
-       res = request_mem_region(res->start, resource_size(res), "wm8505fb");
+       res = request_mem_region(res->start, resource_size(res), DRIVER_NAME);
        if (res == NULL) {
                dev_err(&pdev->dev, "failed to request I/O memory\n");
                ret = -EBUSY;
index f31883f8eaf75ba9f6b7c511b3b1ecee42c27a1a..45832b7ef7d2c39107d719a1c58a378709c5dc57 100644 (file)
@@ -127,13 +127,11 @@ EXPORT_SYMBOL_GPL(wmt_ge_sync);
 static int __devinit wmt_ge_rops_probe(struct platform_device *pdev)
 {
        struct resource *res;
-       int ret;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (res == NULL) {
                dev_err(&pdev->dev, "no I/O memory resource defined\n");
-               ret = -ENODEV;
-               goto error;
+               return -ENODEV;
        }
 
        /* Only one ROP engine is presently supported. */
@@ -145,17 +143,13 @@ static int __devinit wmt_ge_rops_probe(struct platform_device *pdev)
        regbase = ioremap(res->start, resource_size(res));
        if (regbase == NULL) {
                dev_err(&pdev->dev, "failed to map I/O memory\n");
-               ret = -EBUSY;
-               goto error;
+               return -EBUSY;
        }
 
        writel(1, regbase + GE_ENABLE_OFF);
        printk(KERN_INFO "Enabled support for WMT GE raster acceleration\n");
 
        return 0;
-
-error:
-       return ret;
 }
 
 static int __devexit wmt_ge_rops_remove(struct platform_device *pdev)