]> git.karo-electronics.de Git - linux-beck.git/commitdiff
iommu: smar: Fix return value check of create_irq()
authorThomas Gleixner <tglx@linutronix.de>
Wed, 7 May 2014 15:44:10 +0000 (15:44 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 16 May 2014 12:05:19 +0000 (14:05 +0200)
ia64 returns a negative error code when allocation fails andx86
returns 0. Make it handle both.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Grant Likely <grant.likely@linaro.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: x86@kernel.org
Acked-by: Joerg Roedel <joro@8bytes.org>
Cc: linux-ia64@vger.kernel.org
Cc: iommu@lists.linux-foundation.org
Link: http://lkml.kernel.org/r/20140507154336.178850165@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
drivers/iommu/dmar.c

index 39f8b717fe8482f6e757bc7f9064187923b90cca..3ce1f62a091fa2eabd45fed56fd40856ae22a7b9 100644 (file)
@@ -1551,7 +1551,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu)
                return 0;
 
        irq = create_irq();
-       if (!irq) {
+       if (irq <= 0) {
                pr_err("IOMMU: no free vectors\n");
                return -EINVAL;
        }