]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
scsi: hpsa: correct scsi 6byte lba calculation
authorMahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>
Fri, 16 Sep 2016 19:54:23 +0000 (14:54 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 19 Sep 2016 15:54:14 +0000 (11:54 -0400)
Missing 5 bits of byte 1 in the LBA issued by SML.

Reported-by: Mahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Mahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hpsa.c

index e5c02d7cb34b4722521fd4c0c602e72f81ec654c..261b9bba1f0f66583df8930f53a4c68167c6dfd1 100644 (file)
@@ -4565,7 +4565,9 @@ static int fixup_ioaccel_cdb(u8 *cdb, int *cdb_len)
        case READ_6:
        case READ_12:
                if (*cdb_len == 6) {
-                       block = get_unaligned_be16(&cdb[2]);
+                       block = (((cdb[1] & 0x1F) << 16) |
+                               (cdb[2] << 8) |
+                               cdb[3]);
                        block_cnt = cdb[4];
                        if (block_cnt == 0)
                                block_cnt = 256;
@@ -4725,9 +4727,11 @@ static void set_encrypt_ioaccel2(struct ctlr_info *h,
         */
        switch (cmd->cmnd[0]) {
        /* Required? 6-byte cdbs eliminated by fixup_ioaccel_cdb */
-       case WRITE_6:
        case READ_6:
-               first_block = get_unaligned_be16(&cmd->cmnd[2]);
+       case WRITE_6:
+               first_block = (((cmd->cmnd[1] & 0x1F) << 16) |
+                               (cmd->cmnd[2] << 8) |
+                               cmd->cmnd[3]);
                break;
        case WRITE_10:
        case READ_10:
@@ -4977,7 +4981,9 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h,
        case WRITE_6:
                is_write = 1;
        case READ_6:
-               first_block = get_unaligned_be16(&cmd->cmnd[2]);
+               first_block = (((cmd->cmnd[1] & 0x1F) << 16) |
+                               (cmd->cmnd[2] << 8) |
+                               cmd->cmnd[3]);
                block_cnt = cmd->cmnd[4];
                if (block_cnt == 0)
                        block_cnt = 256;