]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: dwc2: add missing shift
authorMatthijs Kooijman <matthijs@stdin.nl>
Fri, 30 Aug 2013 16:45:16 +0000 (18:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 30 Aug 2013 21:14:52 +0000 (14:14 -0700)
This line extracted the available queue space without properly shifting
it. Since the code only cared wether it was zero or not, it worked as
expected without the shift, but adding shift makes the code cleaner.

While we're here, store the result in a helper variable that was already
declared to increase readability a bit more.

Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
Acked-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/dwc2/hcd.c

index f11b4f09800645288e9453712dc27c6912990b9d..9a1e062b72978917a506d5c4ffbb4513b8f29fc9 100644 (file)
@@ -1020,7 +1020,9 @@ static void dwc2_process_periodic_channels(struct dwc2_hsotg *hsotg)
        qh_ptr = hsotg->periodic_sched_assigned.next;
        while (qh_ptr != &hsotg->periodic_sched_assigned) {
                tx_status = readl(hsotg->regs + HPTXSTS);
-               if ((tx_status & TXSTS_QSPCAVAIL_MASK) == 0) {
+               qspcavail = (tx_status & TXSTS_QSPCAVAIL_MASK) >>
+                           TXSTS_QSPCAVAIL_SHIFT;
+               if (qspcavail == 0) {
                        no_queue_space = 1;
                        break;
                }