]> git.karo-electronics.de Git - mv-sheeva.git/commitdiff
xhci: Remove references to HC_STATE_RUNNING.
authorSarah Sharp <sarah.a.sharp@linux.intel.com>
Fri, 11 Mar 2011 21:49:55 +0000 (13:49 -0800)
committerSarah Sharp <sarah.a.sharp@linux.intel.com>
Mon, 14 Mar 2011 01:07:10 +0000 (18:07 -0700)
The USB core will set hcd->state to HC_STATE_RUNNING before calling
xhci_run, so there's no point in setting it twice.  The USB core also
doesn't pay attention to HC_STATE_RUNNING on the resume path anymore; it
uses HCD_RH_RUNNING(), which looks at hcd->flags & (1U <<
HCD_FLAG_RH_RUNNING.  Therefore, it's safe to remove the state set in
xhci_bus_resume().

Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
drivers/usb/host/xhci-hub.c
drivers/usb/host/xhci.c

index 004a46557f9c5020f5d58a0e0da16bb4a1ac0d9a..43e0a099d63420db38b82d66c367bb3dfb420090 100644 (file)
@@ -732,7 +732,6 @@ int xhci_bus_resume(struct usb_hcd *hcd)
        (void) xhci_readl(xhci, &xhci->op_regs->command);
 
        xhci->next_statechange = jiffies + msecs_to_jiffies(5);
-       hcd->state = HC_STATE_RUNNING;
        /* re-enable irqs */
        temp = xhci_readl(xhci, &xhci->op_regs->command);
        temp |= CMD_EIE;
index 63b8db5275e934776f2ebc89b454eb3de14aa4fb..883b4c402c6a5180255fe4809228c9b4d04500ae 100644 (file)
@@ -452,7 +452,6 @@ int xhci_run(struct usb_hcd *hcd)
        xhci_writel(xhci, temp, &xhci->ir_set->irq_control);
 
        /* Set the HCD state before we enable the irqs */
-       hcd->state = HC_STATE_RUNNING;
        temp = xhci_readl(xhci, &xhci->op_regs->command);
        temp |= (CMD_EIE);
        xhci_dbg(xhci, "// Enable interrupts, cmd = 0x%x.\n",