iommu/amd: Convert non-returned local variable to boolean when relevant

This patch was produced using Coccinelle. A simplified version of the
semantic patch is:

@r exists@
identifier f;
local idexpression u8 x;
identifier xname;
@@

f(...) {
...when any
(
  x@xname = 1;
|
  x@xname = 0;
)
...when any
}

@bad exists@
identifier r.f;
local idexpression u8 r.x
expression e1 != {0, 1}, e2;
@@

f(...) {
...when any
(
  x = e1;
|
  x + e2
)
...when any
}

@depends on !bad@
identifier r.f;
local idexpression u8 r.x;
identifier r.xname;
@@

f(...) {
...
++ bool xname;
- int xname;
<...
(
  x =
- 1
+ true
|
  x =
- -1
+ false
)
...>

}

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 98024856df07fc89e744cb1d7b2356a72146de51..5ac2d118f4f40faae10d9fbe9f861afc5835cee0 100644 (file)
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -843,10 +843,10 @@ static void build_inv_iommu_pages(struct iommu_cmd *cmd, u64 address,
                                  size_t size, u16 domid, int pde)
 {
        u64 pages;
-       int s;
+       bool s;
 
        pages = iommu_num_pages(address, size, PAGE_SIZE);
-       s     = 0;
+       s     = false;
 
        if (pages > 1) {
                /*
@@ -854,7 +854,7 @@ static void build_inv_iommu_pages(struct iommu_cmd *cmd, u64 address,
                 * TLB entries for this domain
                 */
                address = CMD_INV_IOMMU_ALL_PAGES_ADDRESS;
-               s = 1;
+               s = true;
        }
 
        address &= PAGE_MASK;
@@ -874,10 +874,10 @@ static void build_inv_iotlb_pages(struct iommu_cmd *cmd, u16 devid, int qdep,
                                  u64 address, size_t size)
 {
        u64 pages;
-       int s;
+       bool s;
 
        pages = iommu_num_pages(address, size, PAGE_SIZE);
-       s     = 0;
+       s     = false;
 
        if (pages > 1) {
                /*
@@ -885,7 +885,7 @@ static void build_inv_iotlb_pages(struct iommu_cmd *cmd, u16 devid, int qdep,
                 * TLB entries for this domain
                 */
                address = CMD_INV_IOMMU_ALL_PAGES_ADDRESS;
-               s = 1;
+               s = true;
        }
 
        address &= PAGE_MASK;