dm raid: don't allow "write behind" with raid4/5/6

Remove CTR_FLAG_MAX_WRITE_BEHIND from raid4/5/6's valid ctr flags.

Only the md raid1 personality supports setting a maximum number
of "write behind" write IOs on any legs set to "write mostly".
"write mostly" enhances throughput with slow links/disks.

Technically the "write behind" value is a write intent bitmap
property only being respected by the raid1 personality.  It allows a
maximum number of "write behind" writes to any "write mostly" raid1
mirror legs to be delayed and avoids reads from such legs.

No other MD personalities supported via dm-raid make use of "write
behind", thus setting this property is superfluous; it wouldn't cause
harm but it is correct to reject it.

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 698b03e9d955b95f2d587834d37a05e39d5f9ae8..9d5c6bb9e35b08d0768ab812b0a1bd9d28e6755c 100644 (file)
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -160,7 +160,6 @@ struct raid_dev {
                                 CTR_FLAG_DAEMON_SLEEP | \
                                 CTR_FLAG_MIN_RECOVERY_RATE | \
                                 CTR_FLAG_MAX_RECOVERY_RATE | \
-                                CTR_FLAG_MAX_WRITE_BEHIND | \
                                 CTR_FLAG_STRIPE_CACHE | \
                                 CTR_FLAG_REGION_SIZE | \
                                 CTR_FLAG_DELTA_DISKS | \
@@ -171,7 +170,6 @@ struct raid_dev {
                                 CTR_FLAG_DAEMON_SLEEP | \
                                 CTR_FLAG_MIN_RECOVERY_RATE | \
                                 CTR_FLAG_MAX_RECOVERY_RATE | \
-                                CTR_FLAG_MAX_WRITE_BEHIND | \
                                 CTR_FLAG_STRIPE_CACHE | \
                                 CTR_FLAG_REGION_SIZE | \
                                 CTR_FLAG_DELTA_DISKS | \