]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: comedi: usbdux: remove the usb_driver (*probe) noise
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Wed, 24 Jul 2013 21:06:58 +0000 (14:06 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2013 20:15:24 +0000 (13:15 -0700)
The dev_dbg() during the usb_driver (*probe) is just added noise.

The dev_err() when a usb_alloc_urb() fails is not necessary. The
allocation failure will have already output a message.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/usbdux.c

index a64967684b68092a538111a01a807a3585d08099..63e302847def6993941a7a8f285084184e84f0b8 100644 (file)
@@ -2299,9 +2299,6 @@ static int usbdux_usb_probe(struct usb_interface *uinterf,
        int i;
        int index;
 
-       dev_dbg(dev, "comedi_: usbdux_: "
-               "finding a free structure for the usb-device\n");
-
        down(&start_stop_sem);
        /* look for a free place in the usbdux array */
        index = -1;
@@ -2318,8 +2315,6 @@ static int usbdux_usb_probe(struct usb_interface *uinterf,
                up(&start_stop_sem);
                return -EMFILE;
        }
-       dev_dbg(dev, "comedi_: usbdux: "
-               "usbduxsub[%d] is ready to connect to comedi.\n", index);
 
        sema_init(&(usbduxsub[index].sem), 1);
        /* save a pointer to the usb device */
@@ -2333,8 +2328,6 @@ static int usbdux_usb_probe(struct usb_interface *uinterf,
        /* will be needed for disconnect */
        usb_set_intfdata(uinterf, &(usbduxsub[index]));
 
-       dev_dbg(dev, "comedi_: usbdux: ifnum=%d\n", usbduxsub[index].ifnum);
-
        /* test if it is high speed (USB 2.0) */
        usbduxsub[index].high_speed =
            (usbduxsub[index].usbdev->speed == USB_SPEED_HIGH);
@@ -2402,8 +2395,6 @@ static int usbdux_usb_probe(struct usb_interface *uinterf,
                /* one frame: 1ms */
                usbduxsub[index].urb_in[i] = usb_alloc_urb(1, GFP_KERNEL);
                if (usbduxsub[index].urb_in[i] == NULL) {
-                       dev_err(dev, "comedi_: usbdux%d: "
-                               "Could not alloc. urb(%d)\n", index, i);
                        tidy_up(&(usbduxsub[index]));
                        up(&start_stop_sem);
                        return -ENOMEM;
@@ -2447,8 +2438,6 @@ static int usbdux_usb_probe(struct usb_interface *uinterf,
                /* one frame: 1ms */
                usbduxsub[index].urb_out[i] = usb_alloc_urb(1, GFP_KERNEL);
                if (usbduxsub[index].urb_out[i] == NULL) {
-                       dev_err(dev, "comedi_: usbdux%d: "
-                               "Could not alloc. urb(%d)\n", index, i);
                        tidy_up(&(usbduxsub[index]));
                        up(&start_stop_sem);
                        return -ENOMEM;
@@ -2488,8 +2477,6 @@ static int usbdux_usb_probe(struct usb_interface *uinterf,
                usbduxsub[index].size_pwm_buf = 512;
                usbduxsub[index].urb_pwm = usb_alloc_urb(0, GFP_KERNEL);
                if (usbduxsub[index].urb_pwm == NULL) {
-                       dev_err(dev, "comedi_: usbdux%d: "
-                               "Could not alloc. pwm urb\n", index);
                        tidy_up(&(usbduxsub[index]));
                        up(&start_stop_sem);
                        return -ENOMEM;