]> git.karo-electronics.de Git - linux-beck.git/commitdiff
i2c: s3c2410: resume the I2C controller earlier
authorVincent Palatin <vpalatin@chromium.org>
Tue, 24 Jun 2014 23:56:54 +0000 (16:56 -0700)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 1 Aug 2014 17:33:10 +0000 (19:33 +0200)
When the wake-up is triggered by the PMIC RTC, the RTC driver is trying
to read the PMIC interrupt status over I2C and fails because the I2C
controller is not resumed yet.
Let's resume the I2C controller earlier in the _noirq phase
(as other hardwares are doing), so we can properly get the wake-up
condition.

[tomasz: Also fixes certain issues on Exynos4-based boards.]

Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Acked-by: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-s3c2410.c

index 6252c051525aca4eef750c29314ed0e8044b21eb..e086fb075f2b9999965a1933206853942180f7d5 100644 (file)
@@ -1267,7 +1267,7 @@ static int s3c24xx_i2c_suspend_noirq(struct device *dev)
        return 0;
 }
 
-static int s3c24xx_i2c_resume(struct device *dev)
+static int s3c24xx_i2c_resume_noirq(struct device *dev)
 {
        struct platform_device *pdev = to_platform_device(dev);
        struct s3c24xx_i2c *i2c = platform_get_drvdata(pdev);
@@ -1285,7 +1285,11 @@ static int s3c24xx_i2c_resume(struct device *dev)
 static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = {
 #ifdef CONFIG_PM_SLEEP
        .suspend_noirq = s3c24xx_i2c_suspend_noirq,
-       .resume = s3c24xx_i2c_resume,
+       .resume_noirq = s3c24xx_i2c_resume_noirq,
+       .freeze_noirq = s3c24xx_i2c_suspend_noirq,
+       .thaw_noirq = s3c24xx_i2c_resume_noirq,
+       .poweroff_noirq = s3c24xx_i2c_suspend_noirq,
+       .restore_noirq = s3c24xx_i2c_resume_noirq,
 #endif
 };