]> git.karo-electronics.de Git - linux-beck.git/commitdiff
drm/i915/dsi: update reset and power sequences in panel prepare/unprepare hooks
authorJani Nikula <jani.nikula@intel.com>
Mon, 19 Sep 2016 12:02:27 +0000 (15:02 +0300)
committerJani Nikula <jani.nikula@intel.com>
Mon, 19 Sep 2016 15:37:45 +0000 (18:37 +0300)
Based on the documentation alone, it's anyone's guess when exactly we
should be running these sequences. Add power on/off sequences where they
feel logical and update assert/deassert reset. The drm panel hooks don't
currently offer us more granularity anyway.

v2: update assert/deassert reset as well (Ville)

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1543320494df953fa073e136248238eaa1eed059.1474286487.git.jani.nikula@intel.com
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c

index 29156995a265f3bf31f400d1e5c8edf3dcdee962..2c5d14eb785192ed08fff48634b9fe676222e548 100644 (file)
@@ -459,6 +459,8 @@ static void generic_exec_sequence(struct drm_panel *panel, enum mipi_seq seq_id)
 static int vbt_panel_prepare(struct drm_panel *panel)
 {
        generic_exec_sequence(panel, MIPI_SEQ_ASSERT_RESET);
+       generic_exec_sequence(panel, MIPI_SEQ_POWER_ON);
+       generic_exec_sequence(panel, MIPI_SEQ_DEASSERT_RESET);
        generic_exec_sequence(panel, MIPI_SEQ_INIT_OTP);
 
        return 0;
@@ -466,7 +468,8 @@ static int vbt_panel_prepare(struct drm_panel *panel)
 
 static int vbt_panel_unprepare(struct drm_panel *panel)
 {
-       generic_exec_sequence(panel, MIPI_SEQ_DEASSERT_RESET);
+       generic_exec_sequence(panel, MIPI_SEQ_ASSERT_RESET);
+       generic_exec_sequence(panel, MIPI_SEQ_POWER_OFF);
 
        return 0;
 }