]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
net: fec: use swab32s() instead of cpu_to_be32()
authorLothar Waßmann <LW@KARO-electronics.de>
Mon, 17 Nov 2014 09:51:22 +0000 (10:51 +0100)
committerNitin Garg <nitin.garg@freescale.com>
Fri, 16 Jan 2015 03:18:38 +0000 (21:18 -0600)
when swap_buffer() is being called, we know for sure, that we need to
byte swap the data. Furthermore, this function is called for swapping
data in both directions. Thus cpu_to_be32() is semantically not
correct for all use cases. Use swab32s() to reflect this.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec_main.c

index d2c7907a3403a65c96432d44b879525f1568de09..955c2a07d842d5fbd273d0425228ee14d7e71039 100644 (file)
@@ -297,7 +297,7 @@ static void *swap_buffer(void *bufaddr, int len)
        unsigned int *buf = bufaddr;
 
        for (i = 0; i < DIV_ROUND_UP(len, 4); i++, buf++)
-               *buf = cpu_to_be32(*buf);
+               swab32s(buf);
 
        return bufaddr;
 }