]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
backlight: tosa: fix checkpatch error and warning
authorJingoo Han <jg1.han@samsung.com>
Sat, 3 Nov 2012 00:42:42 +0000 (11:42 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 7 Nov 2012 04:15:22 +0000 (15:15 +1100)
This patch fixes the checkpatch error and warning as below:

WARNING: line over 80 characters
ERROR: spaces required around that '?' (ctx:VxW)
ERROR: space required after that ',' (ctx:VxV)

Also, unnecessary lines are removed.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/video/backlight/tosa_bl.c
drivers/video/backlight/tosa_lcd.c

index 49342e1d20beaba317d948219bcea9073499c662..03c6ec21a6096eee067fb5033eb4ece5712b85cd 100644 (file)
@@ -90,7 +90,8 @@ static int __devinit tosa_bl_probe(struct i2c_client *client,
        if (!data)
                return -ENOMEM;
 
-       data->comadj = sharpsl_param.comadj == -1 ? COMADJ_DEFAULT : sharpsl_param.comadj;
+       data->comadj = sharpsl_param.comadj == -1 ?
+                       COMADJ_DEFAULT : sharpsl_param.comadj;
 
        ret = devm_gpio_request(&client->dev, TOSA_GPIO_BL_C20MA, "backlight");
        if (ret) {
@@ -163,7 +164,6 @@ static const struct i2c_device_id tosa_bl_id[] = {
        { },
 };
 
-
 static struct i2c_driver tosa_bl_driver = {
        .driver = {
                .name           = "tosa-bl",
index 33047a66cc242baf29a20c7bc0f3ced47682350f..bcd97c55b42fddaecedfcdd31c27025299616e38 100644 (file)
@@ -63,7 +63,7 @@ static int tosa_tg_send(struct spi_device *spi, int adrs, uint8_t data)
 int tosa_bl_enable(struct spi_device *spi, int enable)
 {
        /* bl_enable GP04=1 otherwise GP04=0*/
-       return tosa_tg_send(spi, TG_GPODR2, enable? 0x01 : 0x00);
+       return tosa_tg_send(spi, TG_GPODR2, enable ? 0x01 : 0x00);
 }
 EXPORT_SYMBOL(tosa_bl_enable);
 
@@ -91,15 +91,17 @@ static void tosa_lcd_tg_on(struct tosa_lcd_data *data)
        tosa_tg_send(spi, TG_PNLCTL, value);
 
        /* TG LCD pannel power up */
-       tosa_tg_send(spi, TG_PINICTL,0x4);
+       tosa_tg_send(spi, TG_PINICTL, 0x4);
        mdelay(50);
 
        /* TG LCD GVSS */
-       tosa_tg_send(spi, TG_PINICTL,0x0);
+       tosa_tg_send(spi, TG_PINICTL, 0x0);
 
        if (!data->i2c) {
-               /* after the pannel is powered up the first time, we can access the i2c bus */
-               /* so probe for the DAC */
+               /*
+                * after the pannel is powered up the first time,
+                * we can access the i2c bus so probe for the DAC
+                */
                struct i2c_adapter *adap = i2c_get_adapter(0);
                struct i2c_board_info info = {
                        .type   = "tosa-bl",
@@ -115,11 +117,11 @@ static void tosa_lcd_tg_off(struct tosa_lcd_data *data)
        struct spi_device *spi = data->spi;
 
        /* TG LCD VHSA off */
-       tosa_tg_send(spi, TG_PINICTL,0x4);
+       tosa_tg_send(spi, TG_PINICTL, 0x4);
        mdelay(50);
 
        /* TG LCD signal off */
-       tosa_tg_send(spi, TG_PINICTL,0x6);
+       tosa_tg_send(spi, TG_PINICTL, 0x6);
        mdelay(50);
 
        /* TG Off */