]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: usbdux: remove an unnecessary dev_info()
authorIan Abbott <abbotti@mev.co.uk>
Mon, 2 Apr 2012 11:00:59 +0000 (12:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 10 Apr 2012 18:23:35 +0000 (11:23 -0700)
usbdux_attach_common() prints two messages via dev_info() that shows a
device has been attached.  The first of these messages includes an index
into a static array that the function determines by pointer subtraction,
assuming the pointer passed to the function points to an element of the
array.  Dan Carpenter pointed out that this was kind of ugly.  Since the
dev_info() that prints the array index doesn't add anything useful
(since no other messages print the array index and nothing else uses
it), let's just get rid of it.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/usbdux.c

index c3f928f0ac5b1e97d9135766cc679958861a7baf..3d300eff493f145ff9e1de5a093f7be3f1b7f4d1 100644 (file)
@@ -2623,7 +2623,6 @@ static int usbdux_attach_common(struct comedi_device *dev,
                                void *aux_data, int aux_len)
 {
        int ret;
-       int index = (int)(udev - usbduxsub);
        struct comedi_subdevice *s = NULL;
 
        down(&udev->sem);
@@ -2654,9 +2653,6 @@ static int usbdux_attach_common(struct comedi_device *dev,
                return ret;
        }
 
-       dev_info(&udev->interface->dev,
-                "comedi%d: usb-device %d is attached to comedi.\n",
-                dev->minor, index);
        /* private structure is also simply the usb-structure */
        dev->private = udev;