]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
scsi: fnic: Ratelimit printks to avoid flooding when vlan is not set by the switch.i
authorSatish Kharat <satishkh@cisco.com>
Wed, 1 Mar 2017 00:11:57 +0000 (16:11 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 23 Mar 2017 13:51:25 +0000 (09:51 -0400)
This is to avoid the log from being filled with vlan discovery messages
when there is no vlan configured on the switch.

Signed-off-by: Satish Kharat <satishkh@cisco.com>
Signed-off-by: Sesidhar Baddela <sebaddel@cisco.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/fnic/fnic_fcs.c

index 3b7da66e277188c5e5a14d5c4f18b6942f2f2dc8..8d2d86e0bc720a51629d75e561afaa2ce8f9d2af 100644 (file)
@@ -342,8 +342,11 @@ static void fnic_fcoe_send_vlan_req(struct fnic *fnic)
 
        fnic_fcoe_reset_vlans(fnic);
        fnic->set_vlan(fnic, 0);
-       FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
-                 "Sending VLAN request...\n");
+
+       if (printk_ratelimit())
+               FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
+                         "Sending VLAN request...\n");
+
        skb = dev_alloc_skb(sizeof(struct fip_vlan));
        if (!skb)
                return;
@@ -1313,10 +1316,11 @@ void fnic_handle_fip_timer(struct fnic *fnic)
 
        spin_lock_irqsave(&fnic->vlans_lock, flags);
        if (list_empty(&fnic->vlans)) {
-               /* no vlans available, try again */
-               FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host,
-                         "Start VLAN Discovery\n");
                spin_unlock_irqrestore(&fnic->vlans_lock, flags);
+               /* no vlans available, try again */
+               if (printk_ratelimit())
+                       FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host,
+                                 "Start VLAN Discovery\n");
                fnic_event_enq(fnic, FNIC_EVT_START_VLAN_DISC);
                return;
        }
@@ -1332,10 +1336,11 @@ void fnic_handle_fip_timer(struct fnic *fnic)
                spin_unlock_irqrestore(&fnic->vlans_lock, flags);
                break;
        case FIP_VLAN_FAILED:
-               /* if all vlans are in failed state, restart vlan disc */
-               FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host,
-                         "Start VLAN Discovery\n");
                spin_unlock_irqrestore(&fnic->vlans_lock, flags);
+               /* if all vlans are in failed state, restart vlan disc */
+               if (printk_ratelimit())
+                       FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host,
+                                 "Start VLAN Discovery\n");
                fnic_event_enq(fnic, FNIC_EVT_START_VLAN_DISC);
                break;
        case FIP_VLAN_SENT: