]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
scsi: lpfc: Replace pci_pool_alloc by pci_pool_zalloc
authorSouptick Joarder <jrdr.linux@gmail.com>
Mon, 28 Nov 2016 09:52:37 +0000 (15:22 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 30 Nov 2016 16:40:20 +0000 (11:40 -0500)
In lpfc_new_scsi_buf_s3() and lpfc_new_scsi_buf_s4() pci_pool_alloc
followed by memset will be replaced by pci_pool_zalloc()

Signed-off-by: Souptick joarder <jrdr.linux@gmail.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Acked-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_scsi.c

index 1b0ef79d0821cdbd5b8d63375cc17086d0741db3..ad350d969bdca637cc879ab54950e881022b11b8 100644 (file)
@@ -413,15 +413,13 @@ lpfc_new_scsi_buf_s3(struct lpfc_vport *vport, int num_to_alloc)
                 * struct fcp_cmnd, struct fcp_rsp and the number of bde's
                 * necessary to support the sg_tablesize.
                 */
-               psb->data = pci_pool_alloc(phba->lpfc_scsi_dma_buf_pool,
+               psb->data = pci_pool_zalloc(phba->lpfc_scsi_dma_buf_pool,
                                        GFP_KERNEL, &psb->dma_handle);
                if (!psb->data) {
                        kfree(psb);
                        break;
                }
 
-               /* Initialize virtual ptrs to dma_buf region. */
-               memset(psb->data, 0, phba->cfg_sg_dma_buf_size);
 
                /* Allocate iotag for psb->cur_iocbq. */
                iotag = lpfc_sli_next_iotag(phba, &psb->cur_iocbq);
@@ -821,13 +819,12 @@ lpfc_new_scsi_buf_s4(struct lpfc_vport *vport, int num_to_alloc)
                 * for the struct fcp_cmnd, struct fcp_rsp and the number
                 * of bde's necessary to support the sg_tablesize.
                 */
-               psb->data = pci_pool_alloc(phba->lpfc_scsi_dma_buf_pool,
+               psb->data = pci_pool_zalloc(phba->lpfc_scsi_dma_buf_pool,
                                                GFP_KERNEL, &psb->dma_handle);
                if (!psb->data) {
                        kfree(psb);
                        break;
                }
-               memset(psb->data, 0, phba->cfg_sg_dma_buf_size);
 
                /*
                 * 4K Page alignment is CRITICAL to BlockGuard, double check