]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
usb: musb: da8xx: use platform_device_unregister in da8xx_remove()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 23 Oct 2012 05:26:15 +0000 (13:26 +0800)
committerFelipe Balbi <balbi@ti.com>
Fri, 26 Oct 2012 08:09:46 +0000 (11:09 +0300)
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.

Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in error
cases.  All other usage is a bug.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/musb/da8xx.c

index 2366b818443b5e648756dbda25c6d88e65e9c371..e94f556c6aea152c7069ac19b85b575cc0f7e73b 100644 (file)
@@ -573,8 +573,7 @@ static int __devexit da8xx_remove(struct platform_device *pdev)
        struct da8xx_glue               *glue = platform_get_drvdata(pdev);
 
        musb_put_id(&pdev->dev, glue->musb->id);
-       platform_device_del(glue->musb);
-       platform_device_put(glue->musb);
+       platform_device_unregister(glue->musb);
        clk_disable(glue->clk);
        clk_put(glue->clk);
        kfree(glue);