]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
cfg80211 debugfs: Cleanup some checkpatch issues
authorPichugin Dmitry <smokeman85@gmail.com>
Sat, 28 Jan 2017 14:06:53 +0000 (17:06 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 8 Feb 2017 08:15:59 +0000 (09:15 +0100)
This fixes the checkpatch.pl warnings:
* Macros should not use a trailing semicolon.
* Spaces required around that '='.
* Symbolic permissions 'S_IRUGO' are not preferred.

Signed-off-by: Dmitriy Pichugin <smokeman85@gmail.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/debugfs.c

index 5d453916a4179877ff2f7d0b45f908905b4e5d22..30fc6eb352bccdf70a9e8433af0aae82bf5157cd 100644 (file)
@@ -17,7 +17,7 @@
 static ssize_t name## _read(struct file *file, char __user *userbuf,   \
                            size_t count, loff_t *ppos)                 \
 {                                                                      \
-       struct wiphy *wiphy= file->private_data;                \
+       struct wiphy *wiphy = file->private_data;                       \
        char buf[buflen];                                               \
        int res;                                                        \
                                                                        \
@@ -29,14 +29,14 @@ static const struct file_operations name## _ops = {                 \
        .read = name## _read,                                           \
        .open = simple_open,                                            \
        .llseek = generic_file_llseek,                                  \
-};
+}
 
 DEBUGFS_READONLY_FILE(rts_threshold, 20, "%d",
-                     wiphy->rts_threshold)
+                     wiphy->rts_threshold);
 DEBUGFS_READONLY_FILE(fragmentation_threshold, 20, "%d",
                      wiphy->frag_threshold);
 DEBUGFS_READONLY_FILE(short_retry_limit, 20, "%d",
-                     wiphy->retry_short)
+                     wiphy->retry_short);
 DEBUGFS_READONLY_FILE(long_retry_limit, 20, "%d",
                      wiphy->retry_long);
 
@@ -103,7 +103,7 @@ static const struct file_operations ht40allow_map_ops = {
 };
 
 #define DEBUGFS_ADD(name)                                              \
-       debugfs_create_file(#name, S_IRUGO, phyd, &rdev->wiphy, &name## _ops);
+       debugfs_create_file(#name, 0444, phyd, &rdev->wiphy, &name## _ops)
 
 void cfg80211_debugfs_rdev_add(struct cfg80211_registered_device *rdev)
 {