]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: addi_apci_035: board has eeprom
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 14 Oct 2014 17:44:32 +0000 (10:44 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2014 07:48:54 +0000 (15:48 +0800)
As indicated in the boardinfo, the hardware has an eeprom. Simplify
the board attach code and remove the boardinfo.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi_apci_035.c

index a197f64e63c1f85b35fc7ca3f748f8a518ddfc38..ed4ed17888a12764b8554c8a11397e0cd9298135 100644 (file)
@@ -15,7 +15,6 @@
 static const struct addi_board apci035_boardtypes[] = {
        {
                .name                   = "apci035",
-               .i_PCIEeprom            = 1,
                .pc_EepromChip          = "S5920",
                .i_NbrAiChannel         = 16,
                .i_NbrAiChannelDiff     = 8,
@@ -95,22 +94,15 @@ static int apci035_auto_attach(struct comedi_device *dev,
                        dev->irq = pcidev->irq;
        }
 
-       /*  Read eepeom and fill addi_board Structure */
+       /*  Set 3 wait stait */
+       outl(0x80808082, devpriv->i_IobaseAmcc + 0x60);
 
-       if (this_board->i_PCIEeprom) {
-               if (!(strcmp(this_board->pc_EepromChip, "S5920"))) {
-                       /*  Set 3 wait stait */
-                       if (!(strcmp(dev->board_name, "apci035")))
-                               outl(0x80808082, devpriv->i_IobaseAmcc + 0x60);
-                       else
-                               outl(0x83838383, devpriv->i_IobaseAmcc + 0x60);
-
-                       /*  Enable the interrupt for the controller */
-                       dw_Dummy = inl(devpriv->i_IobaseAmcc + 0x38);
-                       outl(dw_Dummy | 0x2000, devpriv->i_IobaseAmcc + 0x38);
-               }
-               addi_eeprom_read_info(dev, pci_resource_start(pcidev, 0));
-       }
+       /*  Enable the interrupt for the controller */
+       dw_Dummy = inl(devpriv->i_IobaseAmcc + 0x38);
+       outl(dw_Dummy | 0x2000, devpriv->i_IobaseAmcc + 0x38);
+
+       /*  Read eepeom and fill addi_board Structure */
+       addi_eeprom_read_info(dev, pci_resource_start(pcidev, 0));
 
        ret = comedi_alloc_subdevices(dev, 3);
        if (ret)
@@ -156,15 +148,11 @@ static int apci035_auto_attach(struct comedi_device *dev,
 
        /* EEPROM */
        s = &dev->subdevices[2];
-       if (this_board->i_PCIEeprom) {
-               s->type = COMEDI_SUBD_MEMORY;
-               s->subdev_flags = SDF_READABLE | SDF_INTERNAL;
-               s->n_chan = 256;
-               s->maxdata = 0xffff;
-               s->insn_read = i_ADDIDATA_InsnReadEeprom;
-       } else {
-               s->type = COMEDI_SUBD_UNUSED;
-       }
+       s->type = COMEDI_SUBD_MEMORY;
+       s->subdev_flags = SDF_READABLE | SDF_INTERNAL;
+       s->n_chan = 256;
+       s->maxdata = 0xffff;
+       s->insn_read = i_ADDIDATA_InsnReadEeprom;
 
        apci035_reset(dev);