]> git.karo-electronics.de Git - linux-beck.git/commitdiff
video: da8xx-fb: use modedb helper to update var
authorAfzal Mohammed <afzal@ti.com>
Mon, 5 Aug 2013 22:02:22 +0000 (17:02 -0500)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 9 Aug 2013 11:02:41 +0000 (14:02 +0300)
modedb structure is now used to store panel information, run modedb
helper over it for initial update of "var" information instead of
equating each fields.

While at it, remove redundant update of bits_per_pixel.

Note: pixclock is overridden with proper value using an existing code
as currently modedb is having it in Hz instead of ps, this would be
fixed in a later change and this overide would be removed.

Signed-off-by: Afzal Mohammed <afzal@ti.com>
Signed-off-by: Darren Etheridge <detheridge@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/da8xx-fb.c

index 52977b14425f39a4e5855716f1de9ce8ddf206e6..a1f65444b5807af6890e9dc95cd04e6476287a91 100644 (file)
@@ -1329,6 +1329,8 @@ static int fb_probe(struct platform_device *device)
                par->panel_power_ctrl(1);
        }
 
+       fb_videomode_to_var(&da8xx_fb_var, lcdc_info);
+
        if (lcd_init(par, lcd_cfg, lcdc_info) < 0) {
                dev_err(&device->dev, "lcd_init failed\n");
                ret = -EFAULT;
@@ -1381,25 +1383,9 @@ static int fb_probe(struct platform_device *device)
                goto err_release_pl_mem;
        }
 
-       /* Initialize par */
-       da8xx_fb_info->var.bits_per_pixel = lcd_cfg->bpp;
-
-       da8xx_fb_var.xres = lcdc_info->xres;
-       da8xx_fb_var.xres_virtual = lcdc_info->xres;
-
-       da8xx_fb_var.yres         = lcdc_info->yres;
-       da8xx_fb_var.yres_virtual = lcdc_info->yres * LCD_NUM_BUFFERS;
-
        da8xx_fb_var.grayscale =
            lcd_cfg->panel_shade == MONOCHROME ? 1 : 0;
        da8xx_fb_var.bits_per_pixel = lcd_cfg->bpp;
-
-       da8xx_fb_var.hsync_len = lcdc_info->hsync_len;
-       da8xx_fb_var.vsync_len = lcdc_info->vsync_len;
-       da8xx_fb_var.right_margin = lcdc_info->right_margin;
-       da8xx_fb_var.left_margin  = lcdc_info->left_margin;
-       da8xx_fb_var.lower_margin = lcdc_info->lower_margin;
-       da8xx_fb_var.upper_margin = lcdc_info->upper_margin;
        da8xx_fb_var.pixclock = da8xxfb_pixel_clk_period(par);
 
        /* Initialize fbinfo */