]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: comedi: comedi_test: remove use of comedi_error()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Thu, 17 Jul 2014 18:57:45 +0000 (11:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Jul 2014 00:59:02 +0000 (17:59 -0700)
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.

Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/comedi_test.c

index 1e2fb91b78fe4f802006b942a4bab43f4226faed..845a67905ca6edb4ac9d67ce0819e3fd87eb1a15 100644 (file)
@@ -303,8 +303,8 @@ static int waveform_ai_cmd(struct comedi_device *dev,
        struct comedi_cmd *cmd = &s->async->cmd;
 
        if (cmd->flags & TRIG_RT) {
-               comedi_error(dev,
-                            "commands at RT priority not supported in this driver");
+               dev_err(dev->class_dev,
+                       "commands at RT priority not supported in this driver\n");
                return -1;
        }