]> git.karo-electronics.de Git - linux-beck.git/commitdiff
ALSA: ice1712: consider error value
authorSudip Mukherjee <sudip@vectorindia.org>
Fri, 14 Nov 2014 12:42:21 +0000 (18:12 +0530)
committerTakashi Iwai <tiwai@suse.de>
Fri, 14 Nov 2014 13:16:47 +0000 (14:16 +0100)
earlier we were ignoring the return value of snd_ak4114_create and
always returning 0.
now we are returning the actual status. revo_init is calling this
function, and revo_init is checking the return value.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/ice1712/revo.c

index 1112ec1953bebeb8a793dd0e0cb0df604d7b3b9c..1d81ae67757328df9764162b0b92495158ccf89e 100644 (file)
@@ -494,11 +494,13 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice)
                                 ap192_ak4114_write,
                                 ak4114_init_vals, ak4114_init_txcsb,
                                 ice, &spec->ak4114);
+       if (err < 0)
+               return err;
        /* AK4114 in Revo cannot detect external rate correctly.
         * No reason to stop capture stream due to incorrect checks */
        spec->ak4114->check_flags = AK4114_CHECK_NO_RATE;
 
-       return 0; /* error ignored; it's no fatal error */
+       return 0;
 }
 
 static int revo_init(struct snd_ice1712 *ice)