]> git.karo-electronics.de Git - linux-beck.git/commitdiff
drivers/rtc/rtc-ds1307.c: change sysfs function pointer assignment
authorSteffen Trumtrar <s.trumtrar@pengutronix.de>
Mon, 29 Apr 2013 23:20:16 +0000 (16:20 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 30 Apr 2013 01:28:34 +0000 (18:28 -0700)
The current usage of commas instead of semicolons is not wrong, but
affects the readability of the code.

Also, the code would break, if someone puts something between those two
assignments.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Austin Boyle <Austin.Boyle@aviatnet.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-ds1307.c

index b859d3c67f111726864a51f13913602fcb93293c..b53992ab30908e9987735a32cb8b891b95db8e70 100644 (file)
@@ -960,8 +960,8 @@ read_rtc:
                ds1307->nvram->attr.name = "nvram";
                ds1307->nvram->attr.mode = S_IRUGO | S_IWUSR;
                sysfs_bin_attr_init(ds1307->nvram);
-               ds1307->nvram->read = ds1307_nvram_read,
-               ds1307->nvram->write = ds1307_nvram_write,
+               ds1307->nvram->read = ds1307_nvram_read;
+               ds1307->nvram->write = ds1307_nvram_write;
                ds1307->nvram->size = chip->nvram_size;
                ds1307->nvram_offset = chip->nvram_offset;
                err = sysfs_create_bin_file(&client->dev.kobj, ds1307->nvram);