]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
spi: topcliff-pch: fix error return code in pch_spi_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Wed, 22 May 2013 02:55:41 +0000 (10:55 +0800)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 22 May 2013 16:08:36 +0000 (11:08 -0500)
Fix to return -ENOMEM in the platform_device_alloc() error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/spi/spi-topcliff-pch.c

index 963e0f3585072fbeae40fe42dd1e58fe8157e92b..637d728fbeb5b3d2c573baf5c19c72e6dd542a3d 100644 (file)
@@ -1667,6 +1667,7 @@ static int pch_spi_probe(struct pci_dev *pdev,
                pd_dev = platform_device_alloc("pch-spi", i);
                if (!pd_dev) {
                        dev_err(&pdev->dev, "platform_device_alloc failed\n");
+                       retval = -ENOMEM;
                        goto err_platform_device;
                }
                pd_dev_save->pd_save[i] = pd_dev;