]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
NFC: st21nfca: Fix obvious typo when check error code
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 7 Mar 2017 10:25:42 +0000 (12:25 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Wed, 5 Apr 2017 08:07:35 +0000 (10:07 +0200)
We return -ENODEV if ACPI provides a GPIO resource. Looks really wrong.
If it has even been tested?

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/st21nfca/i2c.c

index d16f58ac09bcbcbd1a858fb9408c70bcb1a4b108..c4f0d048359b9cfe080818575770000d816824a8 100644 (file)
@@ -513,9 +513,9 @@ static int st21nfca_hci_i2c_acpi_request_resources(struct i2c_client *client)
        /* Get EN GPIO from ACPI */
        gpiod_ena = devm_gpiod_get_index(dev, ST21NFCA_GPIO_NAME_EN, 1,
                                         GPIOD_OUT_LOW);
-       if (!IS_ERR(gpiod_ena)) {
+       if (IS_ERR(gpiod_ena)) {
                nfc_err(dev, "Unable to get ENABLE GPIO\n");
-               return -ENODEV;
+               return PTR_ERR(gpiod_ena);
        }
 
        phy->gpio_ena = desc_to_gpio(gpiod_ena);