]> git.karo-electronics.de Git - linux-beck.git/commitdiff
staging: comedi: adv_pci1710: remove board attach noise
authorH Hartley Sweeten <hartleys@visionengravers.com>
Tue, 11 Sep 2012 22:08:06 +0000 (15:08 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 12 Sep 2012 16:29:22 +0000 (09:29 -0700)
Remove the kernel message noise during the attach of the board.
Use a simple/clean dev_info at the end of the attach.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/adv_pci1710.c

index 699f267004ad89d1aaec98fecff96a889944198f..e589684415ee6b22d1bbac29e74488f5fa91e7f0 100644 (file)
@@ -1332,8 +1332,6 @@ static int pci1710_attach(struct comedi_device *dev,
        int ret, subdev, n_subdevices;
        unsigned int irq;
 
-       dev_info(dev->class_dev, DRV_NAME ": attach\n");
-
        ret = alloc_private(dev, sizeof(*devpriv));
        if (ret < 0)
                return -ENOMEM;
@@ -1377,15 +1375,8 @@ static int pci1710_attach(struct comedi_device *dev,
                        if (request_irq(irq, interrupt_service_pci1710,
                                        IRQF_SHARED, "Advantech PCI-1710",
                                        dev)) {
-                               dev_dbg(dev->class_dev,
-                                       "unable to allocate IRQ %d, DISABLING IT",
-                                       irq);
                                irq = 0;        /* Can't use IRQ */
-                       } else {
-                               dev_dbg(dev->class_dev, "irq=%u", irq);
                        }
-               } else {
-                       dev_dbg(dev->class_dev, "IRQ disabled");
                }
        } else {
                irq = 0;
@@ -1480,6 +1471,9 @@ static int pci1710_attach(struct comedi_device *dev,
 
        devpriv->valid = 1;
 
+       dev_info(dev->class_dev, "%s attached, irq %sabled\n",
+               dev->board_name, dev->irq ? "en" : "dis");
+
        return 0;
 }