]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
staging: rtl8712: rewrite the right hand side of an assignment
authorAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Thu, 26 Feb 2015 09:35:45 +0000 (11:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Feb 2015 23:23:47 +0000 (15:23 -0800)
This patch rewrites the right hand side of an assignment for
expressions of the form:
a = (a <op> b);
to be:
a <op>= b;
where <op> = << | >>.

This issue was detected and resolved using the following
coccinelle script:

@@
identifier i;
expression e;
@@

-i = (i >> e);
+i >>= e;

@@
identifier i;
expression e;
@@

-i = (i << e);
+i <<= e;

Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_eeprom.c

index 2f145d63fcecbf6b16898e35803c367033fce360..50339e67da071015a0e4c00a4693693fab08efcb 100644 (file)
@@ -64,7 +64,7 @@ static void shift_out_bits(struct _adapter *padapter, u16 data, u16 count)
                udelay(CLOCK_RATE);
                up_clk(padapter, &x);
                down_clk(padapter, &x);
-               mask = mask >> 1;
+               mask >>= 1;
        } while (mask);
        if (padapter->bSurpriseRemoved == true)
                goto out;
@@ -83,7 +83,7 @@ static u16 shift_in_bits(struct _adapter *padapter)
        x &= ~(_EEDO | _EEDI);
        d = 0;
        for (i = 0; i < 16; i++) {
-               d = d << 1;
+               d <<= 1;
                up_clk(padapter, &x);
                if (padapter->bSurpriseRemoved == true)
                        goto out;