]> git.karo-electronics.de Git - karo-tx-linux.git/commitdiff
greybus: arche-apb-ctrl: Do not export any gpios
authorVaibhav Hiremath <vaibhav.hiremath@linaro.org>
Fri, 12 Feb 2016 20:34:19 +0000 (02:04 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Mon, 15 Feb 2016 21:18:40 +0000 (13:18 -0800)
With addition of operational state in driver, user/developer
can switch to FW flashing state through sysfs. So no need to
export any gpios to userspace now.

Testing Done: Tested on EVT1.2 and DB3.5 platform

Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/arche-apb-ctrl.c

index e1df998ca8773eb61502e28fa9d992dcb2483d3a..b888da376b21c48230b469e9245b7af37c75f0cf 100644 (file)
@@ -58,17 +58,6 @@ static inline void assert_reset(unsigned int gpio)
        gpio_set_value(gpio, 0);
 }
 
-/* Export gpio's to user space */
-static void export_gpios(struct arche_apb_ctrl_drvdata *apb)
-{
-       gpio_export(apb->resetn_gpio, false);
-}
-
-static void unexport_gpios(struct arche_apb_ctrl_drvdata *apb)
-{
-       gpio_unexport(apb->resetn_gpio);
-}
-
 /*
  * Note: Please do not modify the below sequence, as it is as per the spec
  */
@@ -407,20 +396,15 @@ int arche_apb_ctrl_probe(struct platform_device *pdev)
                return ret;
        }
 
-       export_gpios(apb);
-
        dev_info(&pdev->dev, "Device registered successfully\n");
        return 0;
 }
 
 int arche_apb_ctrl_remove(struct platform_device *pdev)
 {
-       struct arche_apb_ctrl_drvdata *apb = platform_get_drvdata(pdev);
-
        device_remove_file(&pdev->dev, &dev_attr_state);
        poweroff_seq(pdev);
        platform_set_drvdata(pdev, NULL);
-       unexport_gpios(apb);
 
        return 0;
 }